Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3322f728 authored by Martin Hundebøll's avatar Martin Hundebøll Committed by Greg Kroah-Hartman
Browse files

spi: bcm2835: remove use of uninitialized gpio flags variable 



commit bc7f2cd7559c5595dc38b909ae9a8d43e0215994 upstream.

Removing the duplicate gpio chip select level handling in
bcm2835_spi_setup() left the lflags variable uninitialized. Avoid trhe
use of such variable by passing default flags to
gpiochip_request_own_desc().

Fixes: 5e31ba0c0543 ("spi: bcm2835: fix gpio cs level inversion")
Signed-off-by: default avatarMartin Hundebøll <martin@geanix.com>
Link: https://lore.kernel.org/r/20201105090615.620315-1-martin@geanix.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 572e545d

drivers/spi/spi-bcm2835.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -1179,7 +1179,6 @@ static int bcm2835_spi_setup(struct spi_device *spi) 
	struct spi_controller *ctlr = spi->controller;

	struct spi_controller *ctlr = spi->controller;

	struct bcm2835_spi *bs = spi_controller_get_devdata(ctlr);

	struct bcm2835_spi *bs = spi_controller_get_devdata(ctlr);

	struct gpio_chip *chip;

	struct gpio_chip *chip;

	enum gpio_lookup_flags lflags;

	u32 cs;

	u32 cs;





	/*

	/*
@@ -1247,7 +1246,7 @@ static int bcm2835_spi_setup(struct spi_device *spi) 




	spi->cs_gpiod = gpiochip_request_own_desc(chip, 8 - spi->chip_select,

	spi->cs_gpiod = gpiochip_request_own_desc(chip, 8 - spi->chip_select,

						  DRV_NAME,

						  DRV_NAME,

						  lflags,

						  GPIO_LOOKUP_FLAGS_DEFAULT,

						  GPIOD_OUT_LOW);

						  GPIOD_OUT_LOW);

	if (IS_ERR(spi->cs_gpiod))

	if (IS_ERR(spi->cs_gpiod))

		return PTR_ERR(spi->cs_gpiod);

		return PTR_ERR(spi->cs_gpiod);