Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32dd9e87 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Mauro Carvalho Chehab
Browse files

[media] media: platform: soc_camera_platform : constify v4l2_subdev_* structures 



v4l2_subdev_{core/video}_ops structures are stored in the
fields of the v4l2_subdev_ops structure which are of type const.
Also, v4l2_subdev_ops structure is passed to a function
having its argument of type const. As these structures are never
modified, so declare them as const.
Done using Coccinelle:(One of the scripts)

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct v4l2_subdev_core_ops i@p = {...};

@ok1@
identifier r1.i;
position p;
struct v4l2_subdev_ops obj;
@@
obj.core=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct v4l2_subdev_core_ops i;

File size before:
    text   data	    bss	    dec	    hex	filename
    858	    576	      0	   1434	    59a soc_camera/soc_camera_platform.o

File size after:
  text	   data	    bss	    dec	    hex	filename
   1234	    192	      0	   1426	    592 soc_camera/soc_camera_platform.o

Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent a5bc63f2

drivers/media/platform/soc_camera/soc_camera_platform.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -59,7 +59,7 @@ static int soc_camera_platform_s_power(struct v4l2_subdev *sd, int on) 
	return soc_camera_set_power(p->icd->control, &p->icd->sdesc->subdev_desc, NULL, on);

	return soc_camera_set_power(p->icd->control, &p->icd->sdesc->subdev_desc, NULL, on);

}

}





static struct v4l2_subdev_core_ops platform_subdev_core_ops = {

static const struct v4l2_subdev_core_ops platform_subdev_core_ops = {

	.s_power = soc_camera_platform_s_power,

	.s_power = soc_camera_platform_s_power,

};

};
@@ -110,7 +110,7 @@ static int soc_camera_platform_g_mbus_config(struct v4l2_subdev *sd, 
	return 0;

	return 0;

}

}





static struct v4l2_subdev_video_ops platform_subdev_video_ops = {

static const struct v4l2_subdev_video_ops platform_subdev_video_ops = {

	.s_stream	= soc_camera_platform_s_stream,

	.s_stream	= soc_camera_platform_s_stream,

	.g_mbus_config	= soc_camera_platform_g_mbus_config,

	.g_mbus_config	= soc_camera_platform_g_mbus_config,

};

};
@@ -122,7 +122,7 @@ static const struct v4l2_subdev_pad_ops platform_subdev_pad_ops = { 
	.set_fmt	= soc_camera_platform_fill_fmt,

	.set_fmt	= soc_camera_platform_fill_fmt,

};

};





static struct v4l2_subdev_ops platform_subdev_ops = {

static const struct v4l2_subdev_ops platform_subdev_ops = {

	.core	= &platform_subdev_core_ops,

	.core	= &platform_subdev_core_ops,

	.video	= &platform_subdev_video_ops,

	.video	= &platform_subdev_video_ops,

	.pad	= &platform_subdev_pad_ops,

	.pad	= &platform_subdev_pad_ops,