Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 32d2c172 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: soc-core: reuse rtdcom at snd_soc_rtdcom_add() 



snd_soc_rtdcom_add() is using both "rtdcom" and "new_rtdcom" as
variable name, but these are not used at same time.
Let's reuse rtdcom.

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87h86tahp2.wl-kuninori.morimoto.gx@renesas.com


Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 42849064

sound/soc/soc-core.c

+5 −6
Original line number Diff line number Diff line
@@ -274,7 +274,6 @@ static int snd_soc_rtdcom_add(struct snd_soc_pcm_runtime *rtd, 
			      struct snd_soc_component *component)

{

	struct snd_soc_rtdcom_list *rtdcom;

	struct snd_soc_rtdcom_list *new_rtdcom;



	for_each_rtdcom(rtd, rtdcom) {

		/* already connected */
@@ -282,14 +281,14 @@ static int snd_soc_rtdcom_add(struct snd_soc_pcm_runtime *rtd, 
			return 0;

	}



	new_rtdcom = kmalloc(sizeof(*new_rtdcom), GFP_KERNEL);

	if (!new_rtdcom)

	rtdcom = kmalloc(sizeof(*rtdcom), GFP_KERNEL);

	if (!rtdcom)

		return -ENOMEM;



	new_rtdcom->component = component;

	INIT_LIST_HEAD(&new_rtdcom->list);

	rtdcom->component = component;

	INIT_LIST_HEAD(&rtdcom->list);



	list_add_tail(&new_rtdcom->list, &rtd->component_list);

	list_add_tail(&rtdcom->list, &rtd->component_list);



	return 0;

}