Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3298cf37 authored by Jan Kara's avatar Jan Kara Committed by Linus Torvalds
Browse files

fanotify: remove useless bypass_perm check 



The prepare_for_access_response() function checks whether
group->fanotify_data.bypass_perm is set.  However this test can never be
true because prepare_for_access_response() is called only from
fanotify_read() which means fanotify group is alive with an active fd
while bypass_perm is set from fanotify_release() when all file
descriptors pointing to the group are closed and the group is going
away.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Cc: Eric Paris <eparis@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ddae82d8

fs/notify/fanotify/fanotify_user.c

+0 −8
Original line number Diff line number Diff line
@@ -211,14 +211,6 @@ static int prepare_for_access_response(struct fsnotify_group *group, 
	re->fd = fd;



	mutex_lock(&group->fanotify_data.access_mutex);



	if (atomic_read(&group->fanotify_data.bypass_perm)) {

		mutex_unlock(&group->fanotify_data.access_mutex);

		kmem_cache_free(fanotify_response_event_cache, re);

		FANOTIFY_E(event)->response = FAN_ALLOW;

		return 0;

	}

		

	list_add_tail(&re->list, &group->fanotify_data.access_list);

	mutex_unlock(&group->fanotify_data.access_mutex);