Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3256aaef authored by Vincent Stehlé's avatar Vincent Stehlé Committed by Sagi Grimberg
Browse files

nvmet-rdma: Fix use after free 



Avoid dereferencing the queue pointer in nvmet_rdma_release_queue_work()
after it has been freed by nvmet_rdma_free_queue().

Fixes: d8f7750a ("nvmet-rdma: Correctly handle RDMA device hot removal")
Signed-off-by: default avatarVincent Stehlé <vincent.stehle@intel.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
parent 39bbee4e

drivers/nvme/target/rdma.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -978,10 +978,11 @@ static void nvmet_rdma_release_queue_work(struct work_struct *w) 
		container_of(w, struct nvmet_rdma_queue, release_work);

		container_of(w, struct nvmet_rdma_queue, release_work);

	struct rdma_cm_id *cm_id = queue->cm_id;

	struct rdma_cm_id *cm_id = queue->cm_id;

	struct nvmet_rdma_device *dev = queue->dev;

	struct nvmet_rdma_device *dev = queue->dev;

	enum nvmet_rdma_queue_state state = queue->state;





	nvmet_rdma_free_queue(queue);

	nvmet_rdma_free_queue(queue);





	if (queue->state != NVMET_RDMA_IN_DEVICE_REMOVAL)

	if (state != NVMET_RDMA_IN_DEVICE_REMOVAL)

		rdma_destroy_id(cm_id);

		rdma_destroy_id(cm_id);





	kref_put(&dev->ref, nvmet_rdma_free_dev);

	kref_put(&dev->ref, nvmet_rdma_free_dev);