Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 322b38ce authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva
Browse files

drm/nouveau/nvkm: mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch aims to suppress 29 missing-break-in-switch false positives.

Addresses-Coverity-ID: 1456891 ("Missing break in switch")
Addresses-Coverity-ID: 1324063 ("Missing break in switch")
Addresses-Coverity-ID: 1324063 ("Missing break in switch")
Addresses-Coverity-ID: 141432 ("Missing break in switch")
Addresses-Coverity-ID: 141433 ("Missing break in switch")
Addresses-Coverity-ID: 141434 ("Missing break in switch")
Addresses-Coverity-ID: 141435 ("Missing break in switch")
Addresses-Coverity-ID: 141436 ("Missing break in switch")
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
parent a01bcfd6

drivers/gpu/drm/nouveau/nvkm/engine/disp/hdmi.c

+17 −0
Original line number Diff line number Diff line
@@ -23,38 +23,55 @@ void pack_hdmi_infoframe(struct packed_hdmi_infoframe *packed_frame, 
		 */

	case 17:

		subpack1_high = (raw_frame[16] << 16);

		/* fall through */

	case 16:

		subpack1_high |= (raw_frame[15] << 8);

		/* fall through */

	case 15:

		subpack1_high |= raw_frame[14];

		/* fall through */

	case 14:

		subpack1_low = (raw_frame[13] << 24);

		/* fall through */

	case 13:

		subpack1_low |= (raw_frame[12] << 16);

		/* fall through */

	case 12:

		subpack1_low |= (raw_frame[11] << 8);

		/* fall through */

	case 11:

		subpack1_low |= raw_frame[10];

		/* fall through */

	case 10:

		subpack0_high = (raw_frame[9] << 16);

		/* fall through */

	case 9:

		subpack0_high |= (raw_frame[8] << 8);

		/* fall through */

	case 8:

		subpack0_high |= raw_frame[7];

		/* fall through */

	case 7:

		subpack0_low = (raw_frame[6] << 24);

		/* fall through */

	case 6:

		subpack0_low |= (raw_frame[5] << 16);

		/* fall through */

	case 5:

		subpack0_low |= (raw_frame[4] << 8);

		/* fall through */

	case 4:

		subpack0_low |= raw_frame[3];

		/* fall through */

	case 3:

		header = (raw_frame[2] << 16);

		/* fall through */

	case 2:

		header |= (raw_frame[1] << 8);

		/* fall through */

	case 1:

		header |= raw_frame[0];

		/* fall through */

	case 0:

		break;

	}

drivers/gpu/drm/nouveau/nvkm/engine/dma/usernv04.c

+1 −0
Original line number Diff line number Diff line
@@ -122,6 +122,7 @@ nv04_dmaobj_new(struct nvkm_dma *dma, const struct nvkm_oclass *oclass, 
		break;

	case NV_MEM_ACCESS_WO:

		dmaobj->flags0 |= 0x00008000;

		/* fall through */

	case NV_MEM_ACCESS_RW:

		dmaobj->flags2 |= 0x00000002;

		break;

drivers/gpu/drm/nouveau/nvkm/engine/fifo/nv04.c

+2 −0
Original line number Diff line number Diff line
@@ -117,8 +117,10 @@ nv04_fifo_swmthd(struct nvkm_device *device, u32 chid, u32 addr, u32 data) 
	switch (mthd) {

	case 0x0000 ... 0x0000: /* subchannel's engine -> software */

		nvkm_wr32(device, 0x003280, (engine &= ~mask));

		/* fall through */

	case 0x0180 ... 0x01fc: /* handle -> instance */

		data = nvkm_rd32(device, 0x003258) & 0x0000ffff;

		/* fall through */

	case 0x0100 ... 0x017c:

	case 0x0200 ... 0x1ffc: /* pass method down to sw */

		if (!(engine & mask) && sw)

drivers/gpu/drm/nouveau/nvkm/engine/fifo/nv40.c

+1 −0
Original line number Diff line number Diff line
@@ -81,6 +81,7 @@ nv40_fifo_init(struct nvkm_fifo *base) 
	case 0x49:

	case 0x4b:

		nvkm_wr32(device, 0x002230, 0x00000001);

		/* fall through */

	case 0x40:

	case 0x41:

	case 0x42:

drivers/gpu/drm/nouveau/nvkm/subdev/bios/perf.c

+1 −0
Original line number Diff line number Diff line
@@ -135,6 +135,7 @@ nvbios_perfEp(struct nvkm_bios *bios, int idx, 
		break;

	case 0x30:

		info->script   = nvbios_rd16(bios, perf + 0x02);

		/* fall through */

	case 0x35:

		info->fanspeed = nvbios_rd08(bios, perf + 0x06);

		info->voltage  = nvbios_rd08(bios, perf + 0x07);