Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31b055ef authored by Marcelo Ricardo Leitner's avatar Marcelo Ricardo Leitner Committed by David S. Miller
Browse files

sctp: do not leak chunks that are sent to unconfirmed paths 



Currently, if a chunk is scheduled to be sent through a transport that
is currently unconfirmed, it will be leaked as it is dequeued from outq
and is not re-queued nor freed.

As I'm not aware of any situation that may lead to this situation, I'm
fixing this by freeing the chunk and also logging a trace so that we can
fix the other bug if it ever happens.

Signed-off-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 07b4d6a1

net/sctp/outqueue.c

+5 −1
Original line number Diff line number Diff line
@@ -978,8 +978,12 @@ static int sctp_outq_flush(struct sctp_outq *q, int rtx_timeout, gfp_t gfp) 
			     (new_transport->state == SCTP_UNCONFIRMED) ||

			     (new_transport->state == SCTP_PF)))

				new_transport = asoc->peer.active_path;

			if (new_transport->state == SCTP_UNCONFIRMED)

			if (new_transport->state == SCTP_UNCONFIRMED) {

				WARN_ONCE(1, "Atempt to send packet on unconfirmed path.");

				sctp_chunk_fail(chunk, 0);

				sctp_chunk_free(chunk);

				continue;

			}



			/* Change packets if necessary.  */

			if (new_transport != transport) {