Commit 31901264 authored Oct 16, 2011 by Antonio Quartulli Committed by Marek Lindner Oct 18, 2011

batman-adv: fix tt_local_reset_flags() function



Currently the counter of tt_local_entry structures (tt_local_num) is incremented
each time the tt_local_reset_flags() is invoked causing the node to send wrong
TT_REPONSE packets containing a copy of non-initialised memory thus corrupting
other nodes global translation table and making higher level communication
impossible.

Reported-by: Junkeun Song <jun361@gmail.com>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Acked-by: Junkeun Song <jun361@gmail.com>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>

parent 8b267b31

net/batman-adv/translation-table.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1668,6 +1668,8 @@ static void tt_local_reset_flags(struct bat_priv *bat_priv, uint16_t flags)
		rcu_read_lock();
		hlist_for_each_entry_rcu(tt_local_entry, node,
		head, hash_entry) {
		if (!(tt_local_entry->flags & flags))
		continue;
		tt_local_entry->flags &= ~flags;
		atomic_inc(&bat_priv->num_local_tt);
		}