Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3185bf8c authored by Xiaotian Feng's avatar Xiaotian Feng Committed by Avi Kivity
Browse files

KVM: destroy workqueue on kvm_create_pit() failures 



kernel needs to destroy workqueue if kvm_create_pit() fails, otherwise
after pit is freed, the workqueue is leaked.

Signed-off-by: default avatarXiaotian Feng <dfeng@redhat.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Gleb Natapov <gleb@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gregory Haskins <ghaskins@novell.com>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
parent f45755b8

arch/x86/kvm/i8254.c

+1 −1
Original line number Diff line number Diff line
@@ -742,7 +742,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags) 
	kvm_unregister_irq_mask_notifier(kvm, 0, &pit->mask_notifier);

	kvm_unregister_irq_ack_notifier(kvm, &pit_state->irq_ack_notifier);

	kvm_free_irq_source_id(kvm, pit->irq_source_id);



	destroy_workqueue(pit->wq);

	kfree(pit);

	return NULL;

}