Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31669500 authored by Jingoo Han's avatar Jingoo Han Committed by David S. Miller
Browse files

net: sfc: remove unnecessary pci_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0d74c42f

drivers/net/ethernet/sfc/efx.c

+0 −2
Original line number Diff line number Diff line
@@ -2643,7 +2643,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev) 
	netif_dbg(efx, drv, efx->net_dev, "shutdown successful\n");



	efx_fini_struct(efx);

	pci_set_drvdata(pci_dev, NULL);

	free_netdev(efx->net_dev);



	pci_disable_pcie_error_reporting(pci_dev);
@@ -2837,7 +2836,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev, 
 fail2:

	efx_fini_struct(efx);

 fail1:

	pci_set_drvdata(pci_dev, NULL);

	WARN_ON(rc > 0);

	netif_dbg(efx, drv, efx->net_dev, "initialisation failed. rc=%d\n", rc);

	free_netdev(net_dev);