Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 313aca5a authored by Wenwen Wang's avatar Wenwen Wang Committed by Tudor Ambarus
Browse files

mtd: spi-nor: fix a memory leak bug 



In spi_nor_parse_4bait(), 'dwords' is allocated through kmalloc(). However,
it is not deallocated in the following execution if spi_nor_read_sfdp()
fails, leading to a memory leak. To fix this issue, free 'dwords' before
returning the error.

Fixes: 816873ea ("mtd: spi-nor: parse SFDP 4-byte Address Instruction Table")
Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
parent 3e9e38d9

drivers/mtd/spi-nor/spi-nor.c

+1 −1
Original line number Diff line number Diff line
@@ -3957,7 +3957,7 @@ static int spi_nor_parse_4bait(struct spi_nor *nor, 
	addr = SFDP_PARAM_HEADER_PTP(param_header);

	ret = spi_nor_read_sfdp(nor, addr, len, dwords);

	if (ret)

		return ret;

		goto out;



	/* Fix endianness of the 4BAIT DWORDs. */

	for (i = 0; i < SFDP_4BAIT_DWORD_MAX; i++)