Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 311f6fc7 authored by Masatake YAMATO's avatar Masatake YAMATO Committed by David Teigland
Browse files

dlm: release socket on error 



It seems that `sock' allocated by sock_create_kern in
tcp_connect_to_sock() of dlm/fs/lowcomms.c is not released if
dlm_nodeid_to_addr an error.

Acked-by: default avatarChristine Caulfield <ccaulfie@redhat.com>
Signed-off-by: default avatarMasatake YAMATO <yamato@redhat.com>
Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
parent 329fc4c3

fs/dlm/lowcomms.c

+3 −1
Original line number Diff line number Diff line
@@ -891,8 +891,10 @@ static void tcp_connect_to_sock(struct connection *con) 
		goto out_err;



	memset(&saddr, 0, sizeof(saddr));

	if (dlm_nodeid_to_addr(con->nodeid, &saddr))

	if (dlm_nodeid_to_addr(con->nodeid, &saddr)) {

		sock_release(sock);

		goto out_err;

	}



	sock->sk->sk_user_data = con;

	con->rx_action = receive_from_sock;