Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31063814 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

V4L/DVB (10505): tda8290: Print an error if i2c_gate is not provided 



While here, be sure that gate will be kept disabled if an error occurs.

Cc: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 68d5ce70

drivers/media/common/tuners/tda8290.c

+5 −1
Original line number Diff line number Diff line
@@ -566,8 +566,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe) 
	u8 data;

	struct i2c_msg msg = { .flags = I2C_M_RD, .buf = &data, .len = 1 };



	if (NULL == analog_ops->i2c_gate_ctrl)

	if (!analog_ops->i2c_gate_ctrl) {

		printk(KERN_ERR "tda8290: no gate control were provided!\n");



		return -EINVAL;

	}



	analog_ops->i2c_gate_ctrl(fe, 1);
@@ -615,6 +618,7 @@ static int tda829x_find_tuner(struct dvb_frontend *fe) 


	if (ret != 1) {

		tuner_warn("tuner access failed!\n");

		analog_ops->i2c_gate_ctrl(fe, 0);

		return -EREMOTEIO;

	}