Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30ca9b04 authored by Anson Huang's avatar Anson Huang Committed by Shawn Guo
Browse files

soc: imx: imx-scu: Getting UID from SCU should have response 



The SCU firmware API for getting UID should have response,
otherwise, the message stored in function stack could be
released and then the response data received from SCU will be
stored into that released stack and cause kernel NULL pointer
dump.

Fixes: 73feb4d0 ("soc: imx-scu: Add SoC UID(unique identifier) support")
Signed-off-by: default avatarAnson Huang <Anson.Huang@nxp.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 54ecb8f7

drivers/soc/imx/soc-imx-scu.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -46,7 +46,7 @@ static ssize_t soc_uid_show(struct device *dev, 
	hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;

	hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID;

	hdr->size = 1;

	hdr->size = 1;





	ret = imx_scu_call_rpc(soc_ipc_handle, &msg, false);

	ret = imx_scu_call_rpc(soc_ipc_handle, &msg, true);

	if (ret) {

	if (ret) {

		pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);

		pr_err("%s: get soc uid failed, ret %d\n", __func__, ret);

		return ret;

		return ret;