Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3077c451 authored Jul 30, 2007 by Rusty Russell Committed by Avi Kivity Oct 13, 2007

KVM: Remove three magic numbers



There are several places where hardcoded numbers are used in place of
the easily-available constant, which is poor form.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Avi Kivity <avi@qumranet.com>

parent 8b9cf98c

drivers/kvm/kvm_main.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -413,7 +413,7 @@ static void free_pio_guest_pages(struct kvm_vcpu *vcpu)
	{		{
	int i;		int i;

	for (i = 0; i < 2; ++i)		for (i = 0; i < ARRAY_SIZE(vcpu->pio.guest_pages); ++i)
	if (vcpu->pio.guest_pages[i]) {		if (vcpu->pio.guest_pages[i]) {
	__free_page(vcpu->pio.guest_pages[i]);		__free_page(vcpu->pio.guest_pages[i]);
	vcpu->pio.guest_pages[i] = NULL;		vcpu->pio.guest_pages[i] = NULL;

drivers/kvm/svm.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -241,7 +241,7 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu)
	printk(KERN_DEBUG "%s: NOP\n", __FUNCTION__);		printk(KERN_DEBUG "%s: NOP\n", __FUNCTION__);
	return;		return;
	}		}
	if (svm->next_rip - svm->vmcb->save.rip > 15) {		if (svm->next_rip - svm->vmcb->save.rip > MAX_INST_SIZE) {
	printk(KERN_ERR "%s: ip 0x%llx next 0x%llx\n",		printk(KERN_ERR "%s: ip 0x%llx next 0x%llx\n",
	__FUNCTION__,		__FUNCTION__,
	svm->vmcb->save.rip,		svm->vmcb->save.rip,