Commit 30645307 authored Feb 23, 2019 by Julia Lawall Committed by Tony Lindgren Mar 22, 2019

ARM: OMAP2+: add missing of_node_put after of_device_is_available

Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr

):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
if (<+...of_device_is_available(e)...+>) {
  ... when != of_node_put(e)
(
  return e;
|
+ of_node_put(e);
  return ...;
)
}
// </smpl>

Fixes: e0c827ac ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 3e2cf62e

arch/arm/mach-omap2/display.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -250,8 +250,10 @@ static int __init omapdss_init_of(void)
		if (!node)
		return 0;

		if (!of_device_is_available(node))
		if (!of_device_is_available(node)) {
		of_node_put(node);
		return 0;
		}

		pdev = of_find_device_by_node(node);