Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 305559f1 authored by Chen Gang's avatar Chen Gang Committed by David Vrabel
Browse files

xen/xenbus: Remove BUG_ON() when error string trucated 



xenbus_va_dev_error() is for printing error, so when error string is
too long to be truncated, need not BUG_ON(), still return truncation
string is OK.

Signed-off-by: default avatarChen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
parent c7440a2f

drivers/xen/xenbus/xenbus_client.c

+1 −4
Original line number Diff line number Diff line
@@ -259,7 +259,6 @@ static char *error_path(struct xenbus_device *dev) 
static void xenbus_va_dev_error(struct xenbus_device *dev, int err,

				const char *fmt, va_list ap)

{

	int ret;

	unsigned int len;

	char *printf_buffer = NULL;

	char *path_buffer = NULL;
@@ -270,9 +269,7 @@ static void xenbus_va_dev_error(struct xenbus_device *dev, int err, 
		goto fail;



	len = sprintf(printf_buffer, "%i ", -err);

	ret = vsnprintf(printf_buffer+len, PRINTF_BUFFER_SIZE-len, fmt, ap);



	BUG_ON(len + ret > PRINTF_BUFFER_SIZE-1);

	vsnprintf(printf_buffer+len, PRINTF_BUFFER_SIZE-len, fmt, ap);



	dev_err(&dev->dev, "%s\n", printf_buffer);