Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 303dfbf5 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Greg Kroah-Hartman
Browse files

staging: mei: unlock dev->device_lock mutex on error path in mei_open() 



mei_open() acquires dev->device_lock mutex and try to allocate mei_cl,
but if the allocation fails it goes to return statement. As a result
dev->device_lock left locked.

The patch fixes goto to unlock dev->device_lock mutex on this path.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 17966e3b

drivers/staging/mei/main.c

+1 −1
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ static int mei_open(struct inode *inode, struct file *file) 
	err = -ENOMEM;

	cl = mei_cl_allocate(dev);

	if (!cl)

		goto out;

		goto out_unlock;



	err = -ENODEV;

	if (dev->mei_state != MEI_ENABLED) {