Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 3004f75f authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/sun4i: engine: Add a VBLANK quirk callback 



In some cases, the display engine needs to apply some quirks during the
VBLANK event. In the Display Engine 1.0 case for example, we can only
disable the frontend once the backend has been, which is at VBLANK.

Let's introduce a callback that can be implemented by the various engines.

Reviewed-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/7c298d43aa1500196aa5d15d7a7c0f228c7a6f3c.1516613040.git-series.maxime.ripard@free-electrons.com
parent 656e5f65

drivers/gpu/drm/sun4i/sun4i_tcon.c

+4 −0
Original line number Diff line number Diff line
@@ -540,6 +540,7 @@ static irqreturn_t sun4i_tcon_handler(int irq, void *private) 
	struct sun4i_tcon *tcon = private;

	struct drm_device *drm = tcon->drm;

	struct sun4i_crtc *scrtc = tcon->crtc;

	struct sunxi_engine *engine = scrtc->engine;

	unsigned int status;



	regmap_read(tcon->regs, SUN4I_TCON_GINT0_REG, &status);
@@ -557,6 +558,9 @@ static irqreturn_t sun4i_tcon_handler(int irq, void *private) 
			   SUN4I_TCON_GINT0_VBLANK_INT(1),

			   0);



	if (engine->ops->vblank_quirk)

		engine->ops->vblank_quirk(engine);



	return IRQ_HANDLED;

}

drivers/gpu/drm/sun4i/sunxi_engine.h

+13 −0
Original line number Diff line number Diff line
@@ -85,6 +85,19 @@ struct sunxi_engine_ops { 
	 * This function is optional.

	 */

	void (*disable_color_correction)(struct sunxi_engine *engine);



	/**

	 * @vblank_quirk:

	 *

	 * This callback is used to implement engine-specific

	 * behaviour part of the VBLANK event. It is run with all the

	 * constraints of an interrupt (can't sleep, all local

	 * interrupts disabled) and therefore should be as fast as

	 * possible.

	 *

	 * This function is optional.

	 */

	void (*vblank_quirk)(struct sunxi_engine *engine);

};



/**