Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2fbd69c4 authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: fix invalid user-pointer checks 



Drop invalid user-pointer checks from ioctl handlers.

A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent a98b6900

drivers/usb/serial/ftdi_sio.c

+0 −5
Original line number Diff line number Diff line
@@ -1452,8 +1452,6 @@ static int get_serial_info(struct usb_serial_port *port, 
	struct ftdi_private *priv = usb_get_serial_port_data(port);

	struct serial_struct tmp;



	if (!retinfo)

		return -EFAULT;

	memset(&tmp, 0, sizeof(tmp));

	tmp.flags = priv->flags;

	tmp.baud_base = priv->baud_base;
@@ -1535,9 +1533,6 @@ static int get_lsr_info(struct usb_serial_port *port, 
	struct ftdi_private *priv = usb_get_serial_port_data(port);

	unsigned int result = 0;



	if (!retinfo)

		return -EFAULT;



	if (priv->transmit_empty)

		result = TIOCSER_TEMT;

drivers/usb/serial/io_edgeport.c

+0 −3
Original line number Diff line number Diff line
@@ -1554,9 +1554,6 @@ static int get_serial_info(struct edgeport_port *edge_port, 
{

	struct serial_struct tmp;



	if (!retinfo)

		return -EFAULT;



	memset(&tmp, 0, sizeof(tmp));



	tmp.type		= PORT_16550A;

drivers/usb/serial/io_ti.c

+0 −3
Original line number Diff line number Diff line
@@ -2459,9 +2459,6 @@ static int get_serial_info(struct edgeport_port *edge_port, 
	struct serial_struct tmp;

	unsigned cwait;



	if (!retinfo)

		return -EFAULT;



	cwait = edge_port->port->port.closing_wait;

	if (cwait != ASYNC_CLOSING_WAIT_NONE)

		cwait = jiffies_to_msecs(cwait) / 10;

drivers/usb/serial/mos7720.c

+0 −3
Original line number Diff line number Diff line
@@ -1861,9 +1861,6 @@ static int get_serial_info(struct moschip_port *mos7720_port, 
{

	struct serial_struct tmp;



	if (!retinfo)

		return -EFAULT;



	memset(&tmp, 0, sizeof(tmp));



	tmp.type		= PORT_16550A;

drivers/usb/serial/mos7840.c

+0 −3
Original line number Diff line number Diff line
@@ -1956,9 +1956,6 @@ static int mos7840_get_serial_info(struct moschip_port *mos7840_port, 
	if (mos7840_port == NULL)

		return -1;



	if (!retinfo)

		return -EFAULT;



	memset(&tmp, 0, sizeof(tmp));



	tmp.type = PORT_16550A;