Commit 2f6c7699 authored May 30, 2023 by Robert Marko Committed by Greg Kroah-Hartman Jul 27, 2023

mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M



commit dbfbddcddcebc9ce8a08757708d4e4a99d238e44 upstream.

It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does
not work when the core is trying to use REQ_OP_WRITE_ZEROES.

We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W
that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES:
[   18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2

Disabling TRIM makes the error go away, so lets add a quirk for this eMMC
to disable TRIM.

Signed-off-by: Robert Marko <robimarko@gmail.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230530213259.1776512-1-robimarko@gmail.com


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c491e271

drivers/mmc/core/quirks.h

+7 −0

Original line number	Diff line number	Diff line
		@@ -97,6 +97,13 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
		MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
		MMC_QUIRK_TRIM_BROKEN),

		/*
		* Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
		* support being used to offload WRITE_ZEROES.
		*/
		MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
		MMC_QUIRK_TRIM_BROKEN),

		/*
		* On Some Kingston eMMCs, performing trim can result in
		* unrecoverable data conrruption occasionally due to a firmware bug.