Commit 2f663539 authored May 17, 2019 by Kefeng Wang Committed by Corey Minyard May 20, 2019

ipmi_si: fix unexpected driver unregister warning



If ipmi_si_platform_init()->platform_driver_register() fails,
platform_driver_unregister() called unconditionally will trigger
following warning,

ipmi_platform: Unable to register driver: -12
------------[ cut here ]------------
Unexpected driver unregister!
WARNING: CPU: 1 PID: 7210 at drivers/base/driver.c:193 driver_unregister+0x60/0x70 drivers/base/driver.c:193

Fix it by adding platform_registered variable, only unregister platform
driver when it is already successfully registered.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Message-Id: <20190517101245.4341-1-wangkefeng.wang@huawei.com>

Signed-off-by: Corey Minyard <cminyard@mvista.com>

parent a188339c

drivers/char/ipmi/ipmi_si_platform.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -19,6 +19,7 @@
		#include "ipmi_si.h"
		#include "ipmi_dmi.h"

		static bool platform_registered;
		static bool si_tryplatform = true;
		#ifdef CONFIG_ACPI
		static bool si_tryacpi = true;
		@@ -469,9 +470,12 @@ void ipmi_si_platform_init(void)
		int rv = platform_driver_register(&ipmi_platform_driver);
		if (rv)
		pr_err("Unable to register driver: %d\n", rv);
		else
		platform_registered = true;
		}

		void ipmi_si_platform_shutdown(void)
		{
		if (platform_registered)
		platform_driver_unregister(&ipmi_platform_driver);
		}