Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ef5df1a authored by Yan, Zheng's avatar Yan, Zheng Committed by Ilya Dryomov
Browse files

ceph: fix infinite loop in get_quota_realm() 



get_quota_realm() enters infinite loop if quota inode has no caps.
This can happen after client gets evicted.

Signed-off-by: default avatar"Yan, Zheng" <zyan@redhat.com>
Reviewed-by: default avatarLuis Henriques <lhenriques@suse.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent ac6713cc

fs/ceph/quota.c

+13 −2
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc, 
		return NULL;



	mutex_lock(&qri->mutex);

	if (qri->inode) {

	if (qri->inode && ceph_is_any_caps(qri->inode)) {

		/* A request has already returned the inode */

		mutex_unlock(&qri->mutex);

		return qri->inode;
@@ -146,7 +146,18 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc, 
		mutex_unlock(&qri->mutex);

		return NULL;

	}

	if (qri->inode) {

		/* get caps */

		int ret = __ceph_do_getattr(qri->inode, NULL,

					    CEPH_STAT_CAP_INODE, true);

		if (ret >= 0)

			in = qri->inode;

		else

			in = ERR_PTR(ret);

	}  else {

		in = ceph_lookup_inode(sb, realm->ino);

	}



	if (IS_ERR(in)) {

		pr_warn("Can't lookup inode %llx (err: %ld)\n",

			realm->ino, PTR_ERR(in));