Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ecca3b2 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Greg Kroah-Hartman
Browse files

net: mdio: introduce a shutdown method to mdio device drivers 



[ Upstream commit cf9579976f724ad517cc15b7caadea728c7e245c ]

MDIO-attached devices might have interrupts and other things that might
need quiesced when we kexec into a new kernel. Things are even more
creepy when those interrupt lines are shared, and in that case it is
absolutely mandatory to disable all interrupt sources.

Moreover, MDIO devices might be DSA switches, and DSA needs its own
shutdown method to unlink from the DSA master, which is a new
requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link
interfaces with the DSA master to get rid of lockdep warnings").

So introduce a ->shutdown method in the MDIO device driver structure.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 31cdcb6d

drivers/net/phy/mdio_device.c

+11 −0
Original line number Diff line number Diff line
@@ -180,6 +180,16 @@ static int mdio_remove(struct device *dev) 
	return 0;

}



static void mdio_shutdown(struct device *dev)

{

	struct mdio_device *mdiodev = to_mdio_device(dev);

	struct device_driver *drv = mdiodev->dev.driver;

	struct mdio_driver *mdiodrv = to_mdio_driver(drv);



	if (mdiodrv->shutdown)

		mdiodrv->shutdown(mdiodev);

}



/**

 * mdio_driver_register - register an mdio_driver with the MDIO layer

 * @new_driver: new mdio_driver to register
@@ -194,6 +204,7 @@ int mdio_driver_register(struct mdio_driver *drv) 
	mdiodrv->driver.bus = &mdio_bus_type;

	mdiodrv->driver.probe = mdio_probe;

	mdiodrv->driver.remove = mdio_remove;

	mdiodrv->driver.shutdown = mdio_shutdown;



	retval = driver_register(&mdiodrv->driver);

	if (retval) {

include/linux/mdio.h

+3 −0
Original line number Diff line number Diff line
@@ -64,6 +64,9 @@ struct mdio_driver { 


	/* Clears up any memory if needed */

	void (*remove)(struct mdio_device *mdiodev);



	/* Quiesces the device on system shutdown, turns off interrupts etc */

	void (*shutdown)(struct mdio_device *mdiodev);

};

#define to_mdio_driver(d)						\

	container_of(to_mdio_common_driver(d), struct mdio_driver, mdiodrv)