Commit 2e85c574 authored Dec 03, 2018 by Dan Carpenter Committed by Stephen Boyd Dec 03, 2018

clk: mmp: Off by one in mmp_clk_add()



The > comparison should be >= or we write one element beyond the end of
the unit->clk_table[] array.

(The unit->clk_table[] array is allocated in the mmp_clk_init() function
and it has unit->nr_clks elements).

Fixes: 4661fda1 ("clk: mmp: add basic support functions for DT support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent d9f5b7f5

drivers/clk/mmp/clk.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -183,7 +183,7 @@ void mmp_clk_add(struct mmp_clk_unit *unit, unsigned int id,
		pr_err("CLK %d has invalid pointer %p\n", id, clk);
		return;
		}
		if (id > unit->nr_clks) {
		if (id >= unit->nr_clks) {
		pr_err("CLK %d is invalid\n", id);
		return;
		}