Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2dfbb644 authored by Michael Hernandez's avatar Michael Hernandez Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Fix incorrect SFUB length used for Secure Flash Update MB Cmd 

commit c868907e1ac6a08a17f8fa9ce482c0a496896e9e upstream.

SFUB length should be in DWORDs when passed to FW.

Fixes: 3f006ac3 ("scsi: qla2xxx: Secure flash update support for ISP28XX")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20191203223657.22109-4-hmadhani@marvell.com


Signed-off-by: default avatarMichael Hernandez <mhernandez@marvell.com>
Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 69b0e7e7

drivers/scsi/qla2xxx/qla_sup.c

+1 −1
Original line number Diff line number Diff line
@@ -2897,7 +2897,7 @@ qla28xx_write_flash_data(scsi_qla_host_t *vha, uint32_t *dwptr, uint32_t faddr, 
			    "Sending Secure Flash MB Cmd\n");

			rval = qla28xx_secure_flash_update(vha, 0, region.code,

				buf_size_without_sfub, sfub_dma,

				sizeof(struct secure_flash_update_block));

				sizeof(struct secure_flash_update_block) >> 2);

			if (rval != QLA_SUCCESS) {

				ql_log(ql_log_warn, vha, 0xffff,

				    "Secure Flash MB Cmd failed %x.", rval);