Commit 2d957a7e authored Sep 05, 2019 by Simon Horman Committed by David S. Miller Sep 06, 2019

ravb: remove undocumented endianness selection

This patch removes the use of the undocumented BOC bit of the CCC register.

Current documentation for EtherAVB (ravb) describes the offset of what the
driver uses as the BOC bit as reserved and that only a value of 0 should be
written. After some internal investigation with Renesas it remains unclear
why this driver accesses these fields but regardless of what the historical
reasons are the current code is considered incorrect.

Based on work by Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 009a4703

drivers/net/ethernet/renesas/ravb.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -216,7 +216,6 @@ enum CCC_BIT {
		CCC_CSEL_HPB = 0x00010000,
		CCC_CSEL_ETH_TX = 0x00020000,
		CCC_CSEL_GMII_REF = 0x00030000,
		CCC_BOC = 0x00100000, /* Undocumented? */
		CCC_LBME = 0x01000000,
		};

drivers/net/ethernet/renesas/ravb_main.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -447,12 +447,6 @@ static int ravb_dmac_init(struct net_device *ndev)
		ravb_ring_format(ndev, RAVB_BE);
		ravb_ring_format(ndev, RAVB_NC);

		#if defined(__LITTLE_ENDIAN)
		ravb_modify(ndev, CCC, CCC_BOC, 0);
		#else
		ravb_modify(ndev, CCC, CCC_BOC, CCC_BOC);
		#endif

		/* Set AVB RX */
		ravb_write(ndev,
		RCR_EFFS \| RCR_ENCF \| RCR_ETS0 \| RCR_ESF \| 0x18000000, RCR);