Commit 2d2ec064 authored Dec 08, 2014 by Rusty Russell Committed by Herbert Xu Dec 22, 2014

hwrng: don't init list element we're about to add to list.



Another interesting anti-pattern.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ebbbfa24

drivers/char/hw_random/core.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -485,7 +485,6 @@ int hwrng_register(struct hwrng *rng)
		goto out_unlock;
		}
		}
		INIT_LIST_HEAD(&rng->list);
		list_add_tail(&rng->list, &rng_list);

		if (old_rng && !rng->init) {