Commit 2cc5d40e authored Jul 21, 2020 by Paulo Alcantara Committed by Greg Kroah-Hartman Jun 14, 2023

cifs: handle empty list of targets in cifs_reconnect()



commit a52930353eaf443489a350a135c5525a4acbbf56 upstream.

In case there were no cached DFS referrals in
reconn_setup_dfs_targets(), set cifs_sb to NULL prior to calling
reconn_set_next_dfs_target() so it would not try to access an empty
tgt_list.

Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Rishabh Bhatnagar <risbhat@amazon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 307ffb71

fs/cifs/connect.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -513,11 +513,13 @@ cifs_reconnect(struct TCP_Server_Info *server)
		sb = NULL;
		} else {
		cifs_sb = CIFS_SB(sb);

		rc = reconn_setup_dfs_targets(cifs_sb, &tgt_list);
		if (rc && (rc != -EOPNOTSUPP)) {
		if (rc) {
		cifs_sb = NULL;
		if (rc != -EOPNOTSUPP) {
		cifs_server_dbg(VFS, "%s: no target servers for DFS failover\n",
		__func__);
		}
		} else {
		server->nr_targets = dfs_cache_get_nr_tgts(&tgt_list);
		}