Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2cc52397 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by Greg Kroah-Hartman
Browse files

ipvs: use explicitly signed chars 



[ Upstream commit 5c26159c97b324dc5174a5713eafb8c855cf8106 ]

The `char` type with no explicit sign is sometimes signed and sometimes
unsigned. This code will break on platforms such as arm, where char is
unsigned. So mark it here as explicitly signed, so that the
todrop_counter decrement and subsequent comparison is correct.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 74fd5839

net/netfilter/ipvs/ip_vs_conn.c

+2 −2
Original line number Diff line number Diff line
@@ -1225,8 +1225,8 @@ static inline int todrop_entry(struct ip_vs_conn *cp) 
	 * The drop rate array needs tuning for real environments.

	 * Called from timer bh only => no locking

	 */

	static const char todrop_rate[9] = {0, 1, 2, 3, 4, 5, 6, 7, 8};

	static char todrop_counter[9] = {0};

	static const signed char todrop_rate[9] = {0, 1, 2, 3, 4, 5, 6, 7, 8};

	static signed char todrop_counter[9] = {0};

	int i;



	/* if the conn entry hasn't lasted for 60 seconds, don't drop it.