Commit 2cbce011 authored May 10, 2022 by Alexandra Winter Committed by Greg Kroah-Hartman May 18, 2022

s390/ctcm: fix variable dereferenced before check



[ Upstream commit 2c50c6867c85afee6f2b3bcbc50fc9d0083d1343 ]

Found by cppcheck and smatch.
smatch complains about
drivers/s390/net/ctcm_sysfs.c:43 ctcm_buffer_write() warn: variable dereferenced before check 'priv' (see line 42)

Fixes: 3c09e264 ("ctcm: rename READ/WRITE defines to avoid redefinitions")
Reported-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1c40e85d

drivers/s390/net/ctcm_sysfs.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -39,11 +39,12 @@ static ssize_t ctcm_buffer_write(struct device *dev,
		struct ctcm_priv *priv = dev_get_drvdata(dev);
		int rc;

		ndev = priv->channel[CTCM_READ]->netdev;
		if (!(priv && priv->channel[CTCM_READ] && ndev)) {
		if (!(priv && priv->channel[CTCM_READ] &&
		priv->channel[CTCM_READ]->netdev)) {
		CTCM_DBF_TEXT(SETUP, CTC_DBF_ERROR, "bfnondev");
		return -ENODEV;
		}
		ndev = priv->channel[CTCM_READ]->netdev;

		rc = kstrtouint(buf, 0, &bs1);
		if (rc)