Commit 2c70bf99 authored Nov 24, 2023 by Hans de Goede Committed by Greg Kroah-Hartman Jan 25, 2024

Input: atkbd - skip ATKBD_CMD_GETID in translated mode

[ Upstream commit 936e4d49ecbc8c404790504386e1422b599dec39 ]

There have been multiple reports of keyboard issues on recent laptop models
which can be worked around by setting i8042.dumbkbd, with the downside
being this breaks the capslock LED.

It seems that these issues are caused by recent laptops getting confused by
ATKBD_CMD_GETID. Rather then adding and endless growing list of quirks for
this, just skip ATKBD_CMD_GETID alltogether on laptops in translated mode.

The main goal of sending ATKBD_CMD_GETID is to skip binding to ps/2
mice/touchpads and those are never used in translated mode.

Examples of laptop models which benefit from skipping ATKBD_CMD_GETID:

* "HP Laptop 15s-fq2xxx", "HP laptop 15s-fq4xxx" and "HP Laptop 15-dy2xxx"
  models the kbd stops working for the first 2 - 5 minutes after boot
  (waiting for EC watchdog reset?)

* On "HP Spectre x360 13-aw2xxx" atkbd fails to probe the keyboard

* At least 9 different Lenovo models have issues with ATKBD_CMD_GETID, see:
  https://github.com/yescallop/atkbd-nogetid



This has been tested on:

1. A MSI B550M PRO-VDH WIFI desktop, where the i8042 controller is not
   in translated mode when no keyboard is plugged in and with a ps/2 kbd
   a "AT Translated Set 2 keyboard" /dev/input/event# node shows up

2. A Lenovo ThinkPad X1 Yoga gen 8 (always has a translated set 2 keyboard)

Reported-by: Shang Ye <yesh25@mail2.sysu.edu.cn>
Closes: https://lore.kernel.org/linux-input/886D6167733841AE+20231017135318.11142-1-yesh25@mail2.sysu.edu.cn/
Closes: https://github.com/yescallop/atkbd-nogetid


Reported-by: gurevitch <mail@gurevit.ch>
Closes: https://lore.kernel.org/linux-input/2iAJTwqZV6lQs26cTb38RNYqxvsink6SRmrZ5h0cBUSuf9NT0tZTsf9fEAbbto2maavHJEOP8GA1evlKa6xjKOsaskDhtJWxjcnrgPigzVo=@gurevit.ch/


Reported-by: Egor Ignatov <egori@altlinux.org>
Closes: https://lore.kernel.org/all/20210609073333.8425-1-egori@altlinux.org/


Reported-by: Anton Zhilyaev <anton@cpp.in>
Closes: https://lore.kernel.org/linux-input/20210201160336.16008-1-anton@cpp.in/
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2086156


Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20231115174625.7462-1-hdegoede@redhat.com


Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 3d9a9c08

drivers/input/keyboard/atkbd.c

+42 −4

Original line number	Diff line number	Diff line
		@@ -715,6 +715,44 @@ static void atkbd_deactivate(struct atkbd *atkbd)
		ps2dev->serio->phys);
		}

		#ifdef CONFIG_X86
		static bool atkbd_is_portable_device(void)
		{
		static const char * const chassis_types[] = {
		"8", /* Portable */
		"9", /* Laptop */
		"10", /* Notebook */
		"14", /* Sub-Notebook */
		"31", /* Convertible */
		"32", /* Detachable */
		};
		int i;

		for (i = 0; i < ARRAY_SIZE(chassis_types); i++)
		if (dmi_match(DMI_CHASSIS_TYPE, chassis_types[i]))
		return true;

		return false;
		}

		/*
		* On many modern laptops ATKBD_CMD_GETID may cause problems, on these laptops
		* the controller is always in translated mode. In this mode mice/touchpads will
		* not work. So in this case simply assume a keyboard is connected to avoid
		* confusing some laptop keyboards.
		*
		* Skipping ATKBD_CMD_GETID ends up using a fake keyboard id. Using a fake id is
		* ok in translated mode, only atkbd_select_set() checks atkbd->id and in
		* translated mode that is a no-op.
		*/
		static bool atkbd_skip_getid(struct atkbd *atkbd)
		{
		return atkbd->translated && atkbd_is_portable_device();
		}
		#else
		static inline bool atkbd_skip_getid(struct atkbd *atkbd) { return false; }
		#endif

		/*
		* atkbd_probe() probes for an AT keyboard on a serio port.
		*/
		@@ -744,12 +782,12 @@ static int atkbd_probe(struct atkbd *atkbd)
		*/

		param[0] = param[1] = 0xa5; /* initialize with invalid values */
		if (ps2_command(ps2dev, param, ATKBD_CMD_GETID)) {
		if (atkbd_skip_getid(atkbd) \|\| ps2_command(ps2dev, param, ATKBD_CMD_GETID)) {

		/*
		* If the get ID command failed, we check if we can at least set the LEDs on
		* the keyboard. This should work on every keyboard out there. It also turns
		* the LEDs off, which we want anyway.
		* If the get ID command was skipped or failed, we check if we can at least set
		* the LEDs on the keyboard. This should work on every keyboard out there.
		* It also turns the LEDs off, which we want anyway.
		*/
		param[0] = 0;
		if (ps2_command(ps2dev, param, ATKBD_CMD_SETLEDS))