Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c231c0c authored by Wenwen Wang's avatar Wenwen Wang Committed by Vinod Koul
Browse files

dmaengine: ti: dma-crossbar: Fix a memory leak bug 



In ti_dra7_xbar_probe(), 'rsv_events' is allocated through kcalloc(). Then
of_property_read_u32_array() is invoked to search for the property.
However, if this process fails, 'rsv_events' is not deallocated, leading to
a memory leak bug. To fix this issue, free 'rsv_events' before returning
the error.

Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/1565938136-7249-1-git-send-email-wenwen@cs.uga.edu


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent d1abaeb3

drivers/dma/ti/dma-crossbar.c

+3 −1
Original line number Diff line number Diff line
@@ -391,8 +391,10 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev) 


		ret = of_property_read_u32_array(node, pname, (u32 *)rsv_events,

						 nelm * 2);

		if (ret)

		if (ret) {

			kfree(rsv_events);

			return ret;

		}



		for (i = 0; i < nelm; i++) {

			ti_dra7_xbar_reserve(rsv_events[i][0], rsv_events[i][1],