Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bf9fbd1 authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso Committed by Greg Kroah-Hartman
Browse files

gtp: fix fragmentation needed check with gso 



[ Upstream commit 4530e5b8e2dad63dcad2206232dd86e4b1489b6c ]

Call skb_gso_validate_network_len() to check if packet is over PMTU.

Fixes: 459aa660 ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 2ab1b7ad

drivers/net/gtp.c

+3 −2
Original line number Diff line number Diff line
@@ -544,8 +544,9 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev, 


	rt->dst.ops->update_pmtu(&rt->dst, NULL, skb, mtu, false);



	if (!skb_is_gso(skb) && (iph->frag_off & htons(IP_DF)) &&

	    mtu < ntohs(iph->tot_len)) {

	if (iph->frag_off & htons(IP_DF) &&

	    ((!skb_is_gso(skb) && skb->len > mtu) ||

	     (skb_is_gso(skb) && !skb_gso_validate_network_len(skb, mtu)))) {

		netdev_dbg(dev, "packet too big, fragmentation needed\n");

		icmp_ndo_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,

			      htonl(mtu));