Commit 2bf9418b authored Jul 08, 2020 by Sean Wang Committed by Greg Kroah-Hartman Aug 19, 2020

mt76: mt7615: fix potential memory leak in mcu message handler



[ Upstream commit 9248c08c3fc4ef816c82aa49d01123f4746d349f ]

Fix potential memory leak in mcu message handler on error condition.

Fixes: 0e6a29e4 ("mt76: mt7615: add support to read temperature from mcu")
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 54c9afe4

drivers/net/wireless/mediatek/mt76/mt7615/mcu.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -119,8 +119,10 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
		struct mt7615_mcu_rxd rxd = (struct mt7615_mcu_rxd )skb->data;
		int ret = 0;

		if (seq != rxd->seq)
		return -EAGAIN;
		if (seq != rxd->seq) {
		ret = -EAGAIN;
		goto out;
		}

		switch (cmd) {
		case -MCU_CMD_PATCH_SEM_CONTROL:
		@@ -134,6 +136,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
		default:
		break;
		}
		out:
		dev_kfree_skb(skb);

		return ret;