Commit 2bf4b33f authored Sep 10, 2018 by Michael J. Ruhl Committed by Jason Gunthorpe Sep 11, 2018

IB/hfi1: Missing return value in error path for user sdma



If the set_txreq_header_agh() function returns an error, the exit path
is chosen.

In this path, the code fails to set the return value.  This will cause
the caller to not realize an error has occurred.

Set the return value correctly in the error path.

Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 3ca633f1

drivers/infiniband/hw/hfi1/user_sdma.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -860,9 +860,11 @@ static int user_sdma_send_pkts(struct user_sdma_request *req, u16 maxpkts)

		changes = set_txreq_header_ahg(req, tx,
		datalen);
		if (changes < 0)
		if (changes < 0) {
		ret = changes;
		goto free_tx;
		}
		}
		} else {
		ret = sdma_txinit(&tx->txreq, 0, sizeof(req->hdr) +
		datalen, user_sdma_txreq_cb);