Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b91868a authored by Isaac J. Manjarres's avatar Isaac J. Manjarres
Browse files

soc: qcom: mem-buf: Fix memory leak in mem_buf_alloc() 



When mem_buf_alloc() encounters an error after mapping the memory
in the stage-2 page tables of the VM, the SGL descriptor is not
freed in the error handling path, so free it.

Change-Id: I6e6fa296311575bb55cd0b9da7a138970e8b8e74
Signed-off-by: default avatarIsaac J. Manjarres <isaacm@codeaurora.org>
parent e00c3830

drivers/soc/qcom/mem-buf.c

+7 −2
Original line number Diff line number Diff line
@@ -1458,12 +1458,17 @@ void *mem_buf_alloc(struct mem_buf_allocation_data *alloc_data) 
	return membuf;



err_get_file:

	if (mem_buf_remove_mem(membuf) < 0)

	if (mem_buf_remove_mem(membuf) < 0) {

		kfree(membuf->sgl_desc);

		goto err_mem_req;

	}

err_add_mem:

	if (mem_buf_unmap_mem_s1(membuf->sgl_desc) < 0)

	if (mem_buf_unmap_mem_s1(membuf->sgl_desc) < 0) {

		kfree(membuf->sgl_desc);

		goto err_mem_req;

	}

err_map_mem_s1:

	kfree(membuf->sgl_desc);

	if (mem_buf_unmap_mem_s2(membuf->memparcel_hdl) < 0)

		goto err_mem_req;

err_map_mem_s2: