Commit 2b7ad435 authored Dec 05, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Jan 18, 2023

selftests/powerpc: Fix resource leaks



[ Upstream commit 8f4ab7da904ab7027ccd43ddb4f0094e932a5877 ]

In check_all_cpu_dscr_defaults, opendir() opens the directory stream.
Add missing closedir() in the error path to release it.

In check_cpu_dscr_default, open() creates an open file descriptor.
Add missing close() in the error path to release it.

Fixes: ebd5858c ("selftests/powerpc: Add test for all DSCR sysfs interfaces")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221205084429.570654-1-linmq006@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 39633b40

tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -24,6 +24,7 @@ static int check_cpu_dscr_default(char *file, unsigned long val)
		rc = read(fd, buf, sizeof(buf));
		if (rc == -1) {
		perror("read() failed");
		close(fd);
		return 1;
		}
		close(fd);
		@@ -65,9 +66,11 @@ static int check_all_cpu_dscr_defaults(unsigned long val)
		if (access(file, F_OK))
		continue;

		if (check_cpu_dscr_default(file, val))
		if (check_cpu_dscr_default(file, val)) {
		closedir(sysfs);
		return 1;
		}
		}
		closedir(sysfs);
		return 0;
		}