Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b2bdfba authored by Steve French's avatar Steve French
Browse files

[CIFS] Streamline SendReceive[2] by using "goto out:" in an error condition 



Signed-off-by: default avatarVolker Lendecke <vl@samba.org>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 8e4f2e8a

fs/cifs/transport.c

+72 −67
Original line number Diff line number Diff line
@@ -619,7 +619,11 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, 
		cERROR(1, ("Frame too large received.  Length: %d  Xid: %d",

			receive_len, xid));

		rc = -EIO;

	} else {		/* rcvd frame is ok */

		goto out;

	}



	/* rcvd frame is ok */



	if (midQ->resp_buf &&

	    (midQ->midState == MID_RESPONSE_RECEIVED)) {
@@ -662,7 +666,6 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, 
		rc = -EIO;

		cFYI(1, ("Bad MID state?"));

	}

	}



out:

	DeleteMidQEntry(midQ);
@@ -809,7 +812,10 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, 
		cERROR(1, ("Frame too large received.  Length: %d  Xid: %d",

			receive_len, xid));

		rc = -EIO;

	} else {		/* rcvd frame is ok */

		goto out;

	}



	/* rcvd frame is ok */



	if (midQ->resp_buf && out_buf

	    && (midQ->midState == MID_RESPONSE_RECEIVED)) {
@@ -846,7 +852,6 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, 
		rc = -EIO;

		cERROR(1, ("Bad MID state?"));

	}

	}



out:

	DeleteMidQEntry(midQ);