Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ab4a939 authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio: vr41xx: Delete vr41xx_gpio_pullupdown() callback 



This API is not used anywhere in the kernel and has remained
unused for years after being introduced.

Over time, we have developed a subsystem to deal with pin
control and this now managed pull up/down.

Delete the old and unused API. If this platform needs it,
we should implement a proper pin controller for it instead.

Cc: Yoichi Yuasa <yuasa@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Acked-by: default avatarPaul Burton <paul.burton@mips.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 2abfb314

arch/mips/include/asm/vr41xx/giu.h

+0 −8
Original line number Diff line number Diff line
@@ -51,12 +51,4 @@ typedef enum { 


extern void vr41xx_set_irq_level(unsigned int pin, irq_level_t level);



typedef enum {

	GPIO_PULL_DOWN,

	GPIO_PULL_UP,

	GPIO_PULL_DISABLE,

} gpio_pull_t;



extern int vr41xx_gpio_pullupdown(unsigned int pin, gpio_pull_t pull);



#endif /* __NEC_VR41XX_GIU_H */

drivers/gpio/gpio-vr41xx.c

+0 −38
Original line number Diff line number Diff line
@@ -371,44 +371,6 @@ static int giu_set_direction(struct gpio_chip *chip, unsigned pin, int dir) 
	return 0;

}



int vr41xx_gpio_pullupdown(unsigned int pin, gpio_pull_t pull)

{

	u16 reg, mask;

	unsigned long flags;



	if ((giu_flags & GPIO_HAS_PULLUPDOWN_IO) != GPIO_HAS_PULLUPDOWN_IO)

		return -EPERM;



	if (pin >= 15)

		return -EINVAL;



	mask = 1 << pin;



	spin_lock_irqsave(&giu_lock, flags);



	if (pull == GPIO_PULL_UP || pull == GPIO_PULL_DOWN) {

		reg = giu_read(GIUTERMUPDN);

		if (pull == GPIO_PULL_UP)

			reg |= mask;

		else

			reg &= ~mask;

		giu_write(GIUTERMUPDN, reg);



		reg = giu_read(GIUUSEUPDN);

		reg |= mask;

		giu_write(GIUUSEUPDN, reg);

	} else {

		reg = giu_read(GIUUSEUPDN);

		reg &= ~mask;

		giu_write(GIUUSEUPDN, reg);

	}



	spin_unlock_irqrestore(&giu_lock, flags);



	return 0;

}

EXPORT_SYMBOL_GPL(vr41xx_gpio_pullupdown);



static int vr41xx_gpio_get(struct gpio_chip *chip, unsigned pin)

{

	u16 reg, mask;