Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a87f090 authored by Leonard Crestez's avatar Leonard Crestez Committed by Lee Jones
Browse files

mfd: bd718x7: Remove hardcoded config for button press duration 



The reset button on imx8mm-evk is tied to PWRON_B pin of bd71847 and the
long press duration is set to zero from OTP. The linux driver overrides
those values and breaks reset from button.

Overwriting OTP or bootloader configuration with some hardcoded defaults
is not desirable, keep already programmed values instead.

Signed-off-by: default avatarLeonard Crestez <leonard.crestez@nxp.com>
Acked-By: default avatarMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 1bb407f1

drivers/mfd/rohm-bd718x7.c

+0 −23
Original line number Diff line number Diff line
@@ -118,29 +118,6 @@ static int bd718xx_i2c_probe(struct i2c_client *i2c, 
		return ret;

	}



	/* Configure short press to 10 milliseconds */

	ret = regmap_update_bits(bd718xx->chip.regmap,

				 BD718XX_REG_PWRONCONFIG0,

				 BD718XX_PWRBTN_PRESS_DURATION_MASK,

				 BD718XX_PWRBTN_SHORT_PRESS_10MS);

	if (ret) {

		dev_err(&i2c->dev,

			"Failed to configure button short press timeout\n");

		return ret;

	}



	/* Configure long press to 10 seconds */

	ret = regmap_update_bits(bd718xx->chip.regmap,

				 BD718XX_REG_PWRONCONFIG1,

				 BD718XX_PWRBTN_PRESS_DURATION_MASK,

				 BD718XX_PWRBTN_LONG_PRESS_10S);



	if (ret) {

		dev_err(&i2c->dev,

			"Failed to configure button long press timeout\n");

		return ret;

	}



	ret = regmap_irq_get_virq(bd718xx->irq_data, BD718XX_INT_PWRBTN_S);



	if (ret < 0) {