Commit 2a72e3b6 authored Jan 26, 2023 by Hans Verkuil Committed by Greg Kroah-Hartman Mar 11, 2023

media: i2c: ov7670: 0 instead of -EINVAL was returned



[ Upstream commit 6a4c664539e6de9b32b65ddcf767ec1bcc1d7f8a ]

If the media bus is unsupported, then return -EINVAL. Instead it
returned 'ret' which happened to be 0.

This fixes a smatch warning:

ov7670.c:1843 ov7670_parse_dt() warn: missing error code? 'ret'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 01b84448 ("media: v4l2: i2c: ov7670: Implement OF mbus configuration")
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d1203342

drivers/media/i2c/ov7670.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1824,7 +1824,7 @@ static int ov7670_parse_dt(struct device *dev,

	if (bus_cfg.bus_type != V4L2_MBUS_PARALLEL) {		if (bus_cfg.bus_type != V4L2_MBUS_PARALLEL) {
	dev_err(dev, "Unsupported media bus type\n");		dev_err(dev, "Unsupported media bus type\n");
	return ret;		return -EINVAL;
	}		}
	info->mbus_config = bus_cfg.bus.parallel.flags;		info->mbus_config = bus_cfg.bus.parallel.flags;