Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a2c8ee2 authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

Revert "i2c: algo-bit: init the bus to a known state"



This reverts commit 3e5f06be. As per
bugzilla #200045, this caused a regression. I don't really see a way to
fix it without having the hardware. So, revert the patch and I will fix
the issue I was seeing originally in the i2c-gpio driver itself. I
couldn't find new users of this algorithm since, so there should be no
one depending on the new behaviour.

Reported-by: default avatarSergey Larin <cerg2010cerg2010@mail.ru>
Fixes: 3e5f06be ("i2c: algo-bit: init the bus to a known state")
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Tested-by: default avatarSergey Larin <cerg2010cerg2010@mail.ru>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
parent 7daf201d
Loading
Loading
Loading
Loading
+0 −5
Original line number Diff line number Diff line
@@ -647,11 +647,6 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
	if (bit_adap->getscl == NULL)
		adap->quirks = &i2c_bit_quirk_no_clk_stretch;

	/* Bring bus to a known state. Looks like STOP if bus is not free yet */
	setscl(bit_adap, 1);
	udelay(bit_adap->udelay);
	setsda(bit_adap, 1);

	ret = add_adapter(adap);
	if (ret < 0)
		return ret;