Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a0d85d9 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: asihpi: Kill BUG_ON() usages 



BUG_ON() is the worst choice for a trivial sanity check.
Either it should be removed or replaced with a softer one like
WARN_ON() if still really needed.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c8445589

sound/pci/asihpi/asihpi.c

+1 −5
Original line number Original line Diff line number Diff line
@@ -558,12 +558,10 @@ static void snd_card_asihpi_pcm_int_start(struct snd_pcm_substream *substream) 
	struct snd_card_asihpi_pcm *dpcm;

	struct snd_card_asihpi_pcm *dpcm;

	struct snd_card_asihpi *card;

	struct snd_card_asihpi *card;





	BUG_ON(!substream);



	dpcm = (struct snd_card_asihpi_pcm *)substream->runtime->private_data;

	dpcm = (struct snd_card_asihpi_pcm *)substream->runtime->private_data;

	card = snd_pcm_substream_chip(substream);

	card = snd_pcm_substream_chip(substream);





	BUG_ON(in_interrupt());

	WARN_ON(in_interrupt());

	tasklet_disable(&card->t);

	tasklet_disable(&card->t);

	card->llmode_streampriv = dpcm;

	card->llmode_streampriv = dpcm;

	tasklet_enable(&card->t);

	tasklet_enable(&card->t);
@@ -578,8 +576,6 @@ static void snd_card_asihpi_pcm_int_stop(struct snd_pcm_substream *substream) 
	struct snd_card_asihpi_pcm *dpcm;

	struct snd_card_asihpi_pcm *dpcm;

	struct snd_card_asihpi *card;

	struct snd_card_asihpi *card;





	BUG_ON(!substream);



	dpcm = (struct snd_card_asihpi_pcm *)substream->runtime->private_data;

	dpcm = (struct snd_card_asihpi_pcm *)substream->runtime->private_data;

	card = snd_pcm_substream_chip(substream);

	card = snd_pcm_substream_chip(substream);