Commit 29b00e60 authored Feb 22, 2019 by Darrick J. Wong Committed by Linus Torvalds Feb 25, 2019

tmpfs: fix uninitialized return value in shmem_link



When we made the shmem_reserve_inode call in shmem_link conditional, we
forgot to update the declaration for ret so that it always has a known
value.  Dan Carpenter pointed out this deficiency in the original patch.

Fixes: 1062af92 ("tmpfs: fix link accounting when a tmpfile is linked in")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: Matej Kupljen <matej.kupljen@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 53a41cb7

mm/shmem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2848,7 +2848,7 @@ static int shmem_create(struct inode dir, struct dentry dentry, umode_t mode,
		static int shmem_link(struct dentry old_dentry, struct inode dir, struct dentry *dentry)
		{
		struct inode *inode = d_inode(old_dentry);
		int ret;
		int ret = 0;

		/*
		* No ordinary (disk based) filesystem counts links as inodes;