Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 299ac444 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

staging: android: ion: Fix return value check in hi6220_ion_probe() 



In case of error, the function ion_device_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarSumit Semwal <sumit.semwal@linaro.org>
Acked-by: default avatarLaura Abbott <labbott@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 29b7d581

drivers/staging/android/ion/hisilicon/hi6220_ion.c

+2 −2
Original line number Diff line number Diff line
@@ -49,8 +49,8 @@ static int hi6220_ion_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, ipdev);



	ipdev->idev = ion_device_create(NULL);

	if (!ipdev->idev)

		return -ENOMEM;

	if (IS_ERR(ipdev->idev))

		return PTR_ERR(ipdev->idev);



	ipdev->data = ion_parse_dt(pdev, hisi_heaps);

	if (IS_ERR(ipdev->data))