Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29118ab9 authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: bugfix for rtnl_lock's range in the hclgevf_reset() 



Since hclgevf_reset_wait() is used to wait for the hardware to complete
the reset, it is not necessary to hold the rtnl_lock during
hclgevf_reset_wait(). So this patch releases the lock for the duration
of hclgevf_reset_wait().

Fixes: 6988eb2a ("net: hns3: Add support to reset the enet/ring mgmt layer")
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a963052e

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

+5 −0
Original line number Diff line number Diff line
@@ -1170,6 +1170,8 @@ static int hclgevf_reset(struct hclgevf_dev *hdev) 
	/* bring down the nic to stop any ongoing TX/RX */

	hclgevf_notify_client(hdev, HNAE3_DOWN_CLIENT);



	rtnl_unlock();



	/* check if VF could successfully fetch the hardware reset completion

	 * status from the hardware

	 */
@@ -1181,12 +1183,15 @@ static int hclgevf_reset(struct hclgevf_dev *hdev) 
			ret);



		dev_warn(&hdev->pdev->dev, "VF reset failed, disabling VF!\n");

		rtnl_lock();

		hclgevf_notify_client(hdev, HNAE3_UNINIT_CLIENT);



		rtnl_unlock();

		return ret;

	}



	rtnl_lock();



	/* now, re-initialize the nic client and ae device*/

	ret = hclgevf_reset_stack(hdev);

	if (ret)