Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 290c30d4 authored by Lihong Kou's avatar Lihong Kou Committed by Jaegeuk Kim
Browse files

f2fs: cleanup the code in build_sit_entries. 



We do not need to set the SBI_NEED_FSCK flag in the error paths, if we
return error here, we will not update the checkpoint flag, so the code
is useless, just remove it.

Signed-off-by: default avatarLihong Kou <koulihong@huawei.com>
Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 27cae0bc

fs/f2fs/segment.c

+0 −2
Original line number Diff line number Diff line
@@ -4168,7 +4168,6 @@ static int build_sit_entries(struct f2fs_sb_info *sbi) 
		if (start >= MAIN_SEGS(sbi)) {

			f2fs_err(sbi, "Wrong journal entry on segno %u",

				 start);

			set_sbi_flag(sbi, SBI_NEED_FSCK);

			err = -EFSCORRUPTED;

			break;

		}
@@ -4208,7 +4207,6 @@ static int build_sit_entries(struct f2fs_sb_info *sbi) 
	if (!err && total_node_blocks != valid_node_count(sbi)) {

		f2fs_err(sbi, "SIT is corrupted node# %u vs %u",

			 total_node_blocks, valid_node_count(sbi));

		set_sbi_flag(sbi, SBI_NEED_FSCK);

		err = -EFSCORRUPTED;

	}