Commit 28f7ff5e authored Nov 15, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Nov 25, 2022

scsi: target: tcm_loop: Fix possible name leak in tcm_loop_setup_hba_bus()



[ Upstream commit bc68e428d4963af0201e92159629ab96948f0893 ]

If device_register() fails in tcm_loop_setup_hba_bus(), the name allocated
by dev_set_name() need be freed. As comment of device_register() says, it
should use put_device() to give up the reference in the error path. So fix
this by calling put_device(), then the name can be freed in kobject_cleanup().
The 'tl_hba' will be freed in tcm_loop_release_adapter(), so it don't need
goto error label in this case.

Fixes: 3703b2c5 ("[SCSI] tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221115015042.3652261-1-yangyingliang@huawei.com


Reviewed-by: Mike Christie <michael.chritie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ec59a132

drivers/target/loopback/tcm_loop.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -394,6 +394,7 @@ static int tcm_loop_setup_hba_bus(struct tcm_loop_hba *tl_hba, int tcm_loop_host
		ret = device_register(&tl_hba->dev);
		if (ret) {
		pr_err("device_register() failed for tl_hba->dev: %d\n", ret);
		put_device(&tl_hba->dev);
		return -ENODEV;
		}

		@@ -1072,7 +1073,7 @@ static struct se_wwn *tcm_loop_make_scsi_hba(
		*/
		ret = tcm_loop_setup_hba_bus(tl_hba, tcm_loop_hba_no_cnt);
		if (ret)
		goto out;
		return ERR_PTR(ret);

		sh = tl_hba->sh;
		tcm_loop_hba_no_cnt++;