Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28c9eb90 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net/wan: dscc4: remove broken dscc4 driver 



Using static analysis, I discovered that the "dpriv->pci_priv->pdev"
pointer is always NULL.  This pointer was supposed to be initialized
during probe and is essential for the driver to work.  It would be easy
to add a "ppriv->pdev = pdev;" to dscc4_found1() but this driver has
been broken since before we started using git and no one has complained
so probably we should just remove it.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1f249677

MAINTAINERS

+0 −6
Original line number Diff line number Diff line
@@ -5582,12 +5582,6 @@ T: git git://linuxtv.org/media_tree.git 
S:	Maintained

F:	drivers/media/radio/dsbr100.c



DSCC4 DRIVER

M:	Francois Romieu <romieu@fr.zoreil.com>

L:	netdev@vger.kernel.org

S:	Maintained

F:	drivers/net/wan/dscc4.c



DT3155 MEDIA DRIVER

M:	Hans Verkuil <hverkuil@xs4all.nl>

L:	linux-media@vger.kernel.org

drivers/net/wan/Kconfig

+0 −14
Original line number Diff line number Diff line
@@ -267,20 +267,6 @@ config FARSYNC 
	  To compile this driver as a module, choose M here: the

	  module will be called farsync.



config DSCC4

	tristate "Etinc PCISYNC serial board support"

	depends on HDLC && PCI && m

	help

	  Driver for Etinc PCISYNC boards based on the Infineon (ex. Siemens)

	  DSCC4 chipset.



	  This is supposed to work with the four port card. Take a look at

	  <http://www.cogenit.fr/dscc4/> for further information about the

	  driver.



	  To compile this driver as a module, choose M here: the

	  module will be called dscc4.



config FSL_UCC_HDLC

	tristate "Freescale QUICC Engine HDLC support"

	depends on HDLC

drivers/net/wan/Makefile

+0 −1
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ obj-$(CONFIG_HOSTESS_SV11) += z85230.o hostess_sv11.o 
obj-$(CONFIG_SEALEVEL_4021)	+= z85230.o	sealevel.o

obj-$(CONFIG_COSA)		+= cosa.o

obj-$(CONFIG_FARSYNC)		+= farsync.o

obj-$(CONFIG_DSCC4)             += dscc4.o

obj-$(CONFIG_X25_ASY)		+= x25_asy.o



obj-$(CONFIG_LANMEDIA)		+= lmc/